Add operation customization for disabling payload signing #3915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
aajtodd
reviewed
Nov 20, 2024
| Some(SignableBody::StreamingUnsignedPayloadTrailer); | ||
| cfg.interceptor_state().store_put(signing_config); | ||
| } | ||
| cfg.interceptor_state() |
There was a problem hiding this comment.
Why does this not need gated anymore?
| assert_eq!("UNSIGNED-PAYLOAD", x_amz_content_sha256); | ||
| } | ||
|
|
||
| // This test ensures that the interceptor's payload signing setting |
There was a problem hiding this comment.
Which interceptor? Also maybe add context on why this is important.
| @@ -65,6 +65,7 @@ val DECORATORS: List<ClientCodegenDecorator> = | |||
| TokenProvidersDecorator(), | |||
| ServiceEnvConfigDecorator(), | |||
| HttpRequestCompressionDecorator(), | |||
| DisablePayloadSigningDecorator(), | |||
There was a problem hiding this comment.
correctness: Should we only be applying this to S3 (and possibly only specific S3 operations)?
I'm guessing most operations are going to require signing and won't work if the payload is unsigned but you'd have to test it. I also can't imagine it matters much for most operations to need unsigned so I'd rather not support this for more than we need to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#3583
Description
This PR adds the ability for users to disable payload signing with an operation customization.
Testing
This PR includes tests.
Checklist
.changelogdirectory, specifying "aws-sdk-rust" in theapplies_tokey.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.